Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI responsiveness while enumerating #5991

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Improve UI responsiveness while enumerating #5991

merged 2 commits into from
Sep 1, 2021

Conversation

hez2010
Copy link
Member

@hez2010 hez2010 commented Aug 31, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Move enumeration to background to unblock UI thread
  • Replace lambdas with local functions

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Before:

before.mp4

After:

after.mp4

@hez2010 hez2010 changed the title Improve UI responsive while enumerating Improve UI responsiveness while enumerating Aug 31, 2021
@yaira2 yaira2 requested a review from gave92 August 31, 2021 14:43
gave92
gave92 previously approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@gave92 gave92 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you! Edit: I'm sure this is sweet too, but I meant to approve #5992. I'll review this shortly.

@gave92 gave92 dismissed their stale review August 31, 2021 17:24

Wrong PR xD

@yaira2 yaira2 requested a review from gave92 September 1, 2021 04:16
@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 1, 2021
@hez2010
Copy link
Member Author

hez2010 commented Sep 1, 2021 •
edited
Loading

@yaichenbaum Just tested with Release build. I think it's ready for merge.

@yaira2
Copy link
Member

yaira2 commented Sep 1, 2021

@hez2010 Thank you! LGTM

@yaira2 yaira2 merged commit bd3ffb1 into files-community:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gave92 gave92 gave92 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hez2010 @yaira2 @gave92