Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul for widgets codebase #4448

Merged
merged 17 commits into from
Apr 5, 2021
Merged

Overhaul for widgets codebase #4448

merged 17 commits into from
Apr 5, 2021

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Apr 4, 2021 •
edited
Loading

Resolved / Related Issues

Details of Changes

  • Widgets can now be "cached" meaning you don't have to load new ones when existing ones are loaded (It's not implemented though).
  • Widgets will no longer be re-loaded when opening settings (from homepage) and going back.
  • (It looks like) widgets loading performance also has improved 🤔
  • It is now possible to implement reordering.
  • Widgets are no longer limited to hardcoded controls. Any control that implements IWidgetItemModel or ICustomWidgetItemModel can be a widget now.
  • IDisposable control - Dispose() will be called for all widgets on their removal
  • @winston-de @yaichenbaum This PR makes displaying custom widgets possible 🎉

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@d2dyno1 d2dyno1 changed the title Moved widgets to GridView Overhaul for widgets codebase Apr 4, 2021
d2dyno1
d2dyno1 commented Apr 4, 2021
View reviewed changes
Files/Views/YourHome.xaml.cs
@@ -188,7 +201,7 @@ protected override async void OnNavigatedTo(NavigationEventArgs eventArgs)
// This IDisposable.Dispose() needs to be called to unhook events in BundlesWidget to avoid memory leaks.
public void Dispose()
Copy link
Member Author

@d2dyno1 d2dyno1 Apr 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this Dispose() will never be called as the comment says, so the widgets never get disposed but the logic is here.
I'll see what could be done in my next PR :)

@d2dyno1 d2dyno1 marked this pull request as ready for review April 5, 2021 11:18
@d2dyno1 d2dyno1 marked this pull request as draft April 5, 2021 11:23
@d2dyno1 d2dyno1 marked this pull request as ready for review April 5, 2021 12:16
@d2dyno1
Copy link
Member Author

d2dyno1 commented Apr 5, 2021 •
edited
Loading

That's... weird..

image

Edit: This has been fixed (Thanks @yaichenbaum)

yaira2
yaira2 previously approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 5, 2021
@yaira2 yaira2 merged commit d066cb8 into files-community:main Apr 5, 2021
@d2dyno1 d2dyno1 deleted the imp_wcb branch April 5, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d2dyno1 @yaira2