Fix: Fixed crash that would occur when holding down ctrl + t

[QuaintMako]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Bug: App crashes when opening a lot of tabs #2145

Validation
How did you test these changes?

• Built and ran the app

[ferrariofilippo]

LGTM
I tested this and it solved the crash

[yaira2]

It solves the crash but I'm wondering if we can have this logic apply to all keyboard shortcuts.

[QuaintMako]

It solves the crash but I'm wondering if we can have this logic apply to all keyboard shortcuts.

We may be able to do that by extending #10416 and developping a kind of shortcut executer side by side.

[yaira2]

Would it make sense to target the branch that has @cinqmilleans work?

[cinqmilleans]

The problem should no longer arise with the new hotkey management.
Before: The shortcut (ctrl + 2, ...) is added when the tab is created. I guess this is limited to 9 or 10 tabs.
After: The shortcut is created when a hotkey is assigned. If the user (or the default) assigned ctrl+2 to the command ShowTab2 (example), the action is assigned even if tab 2 does not exist. When the hotkey is triggered, the action tries to display tab 2 if it exists, otherwise nothing. Hotkeys are only modified when the hotkeys (and not the command) is modified.

We can validate this pr which will correct the problem immediately (I have not tested it).

[QuaintMako]

Does not longer fix the issue. See #2145.