Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "Update SupportedProofTypes (#11988)" #11990

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented May 13, 2024

#11988 was introduces earlier today, to update SupportedProofTypes in Filecoin.StateGetNetworkParams to return the correct ProofsTypes.

But this change caused panics in tooling used for spinning up devnets, and its not clear to me how to fix those, and if there are other connections in the above changes to the Lotus-Miner. For now it seems best to revert this PR, until we have a clearer view of how these pieces are connected.

Proposed Changes

Revert #11988.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@rjan90 rjan90 requested review from rvagg, magik6k and ZenGround0 May 13, 2024 19:36
@rjan90 rjan90 merged commit 74172ba into master May 14, 2024
92 of 186 checks passed
@rjan90 rjan90 deleted the phi-revert-11988 branch May 14, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants