Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load km locale from FilePond #9431

Merged
merged 1 commit into from
May 22, 2024
Merged

Load km locale from FilePond #9431

merged 1 commit into from
May 22, 2024

Conversation

valpuia
Copy link
Contributor

@valpuia valpuia commented Nov 3, 2023

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

This PR should be base on pqina/filepond#943 status. I'll just mark as draft then later will change base on filepond status

@valpuia valpuia marked this pull request as draft November 3, 2023 03:52
@valpuia valpuia marked this pull request as ready for review November 4, 2023 02:00
@valpuia
Copy link
Contributor Author

valpuia commented Nov 4, 2023

Filepond has been merged, but I think I will have the same situation with #9427 anyway marked as ready

@zepfietje zepfietje changed the title added km locale in file-upload.js Load km locale from FilePond Nov 4, 2023
@zepfietje zepfietje added this to the v3 milestone Nov 4, 2023
@danharrin danharrin closed this Nov 4, 2023
@danharrin
Copy link
Member

Please open a PR when we can actually merge it, otherwise it's just clutter really.

@valpuia valpuia mentioned this pull request May 22, 2024
Merged
@danharrin danharrin reopened this May 22, 2024
@danharrin danharrin merged commit 41f0501 into filamentphp:3.x May 22, 2024
9 checks passed
@valpuia valpuia deleted the fix/km-locale-filepond branch May 22, 2024 11:01
@valpuia
Copy link
Contributor Author

valpuia commented May 22, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked i18n
Projects
Roadmap
Archived in project
Milestone
v3
Development

Successfully merging this pull request may close these issues.
3 participants
@valpuia @danharrin @zepfietje