Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow to override ExportFormat with custom enum instance #15439

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

jeremiealvin
Copy link

@jeremiealvin jeremiealvin commented Jan 25, 2025

Description

This code allow to override the ExportFormat enum by implementing a common interface on a new enum.
This allows the developer to create a custom exporter with other formats than the default specified in ExportFormat enum.

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename it to ExportFormat and import it in the original enum as ExportFormatInterface

Please move it to Enums/Contracts

@danharrin danharrin added the enhancement New feature or request label Jan 25, 2025
@danharrin danharrin added this to the v3 milestone Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants