Fix summarizer connection resolver on non-default connections #15407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Laravel model method
resolveConnection
, when called without arguments, returns default database connection, even if model has another connection set.Usually it doesn't matter if syntax is the same between connections but in our case it was returning
MariaDbConnection
instead ofSqlServerConnection
, which has different char escaping.Laravel itself manually passes connection name to
resolveConnection
like here: https://github.com/laravel/framework/blob/6e0e2cbd584a2988348409fe15bb2ead87aeafec/src/Illuminate/Database/Eloquent/Model.php#L1817I believe it is better to use
getConnection
as it sets connection properly as in example above.Visual changes
Functional changes
composer cs
command.