-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Incorrectly hiding the 'Select all X' table link #12853
Fix: Incorrectly hiding the 'Select all X' table link #12853
Conversation
Due to the amount of selected records matching across multiple pages while 'selectCurrentPageOnly()' is set.
Thank you for fixing my bug report. Here is a video showing the case where selectCurrentPageOnly is not used: 2024-05-19.15.01.10.mov |
There is another issue. |
I've changed it so instead of a random string that refreshes on every request, it will only refresh when the page is changed |
Can you test that it still works and let me know please? |
…ct-all-link-behavior
Thanks! |
Description
This PR is related to issue #12781.
The "Select all X" link was hidden by comparing the amount of selected records with the "selectable" records on the page.
But since records stay selected across pages this caused the undesired behavior.
The code change instead checks if the current pages records all are part of the selected records.
Visual changes
Before recording can be found in the issue.
There are a total of 5 selected records matching the pages record count but the link is still shown.
That was previously not possible.
Functional changes
composer cs
command.