Fix footer actions being rendered outside viewport in image editor on mobile devices #12813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the footer actions (Cancel, Save, Reset) are rendered outside of the viewport when the FileUpload image editor is used on most mobile devices (inc. latest iOS and Android Chrome).
This is fixed by using
100dvhinstead of100vh/h-screen. Tailwind'sh-[100dvh]is used instead ofh-dvhto support backwards compatibility for people using custom themes on an older version of Tailwind, as mentioned in this comment.Visual changes
Functional changes
h-screentoh-[100dvh]on the image editor modal.