-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Extra field wrapper attributes #12782
Merged
danharrin
merged 20 commits into
filamentphp:3.x
from
atmonshi:extra-field-wrapper-attributes
May 16, 2024
Merged
Feat: Extra field wrapper attributes #12782
danharrin
merged 20 commits into
filamentphp:3.x
from
atmonshi:extra-field-wrapper-attributes
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danharrin
requested changes
May 15, 2024
…ld-wrapper" This reverts commit 2db2667.
danharrin
requested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do the same for the infolist entry wrapper, and remove the changes to composer.lock
all done 👍, and revert composer.lock |
danharrin
reviewed
May 16, 2024
danharrin
reviewed
May 16, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Method:
extraFieldWrapperAttributes
, for more fields customization without the need for publishing the views.Description
the new method
extraFieldWrapperAttributes
will allow to add classes to thefield-wrapper
. my use case it to highlight some fields by custom CSS.all other
extra*Attributes
will only applies to the input itselfVisual changes:
Screenshots:
with
![Screenshot_2024-05-13_110915](https://private-user-images.githubusercontent.com/1952412/330458675-27c9d2ff-4398-4b43-a263-0726d2edba1d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODUxNDYsIm5iZiI6MTczOTY4NDg0NiwicGF0aCI6Ii8xOTUyNDEyLzMzMDQ1ODY3NS0yN2M5ZDJmZi00Mzk4LTRiNDMtYTI2My0wNzI2ZDJlZGJhMWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMDU0NzI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTA1OWRhNGI0NWEwMTk2NjE1OWI2Y2IzZjA4ZWNlMWNmOGJlMTU0ZmRmOGNhYjFkYmIyNmJhMzM5ZmNiMTQ5ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.cYGKnEFtWkHedpLpGq9WusiHJQ6PNnBUoMTFIkCpi8g)
extra*Attributes
:with extraFieldWrapperAttributes:
![Screenshot_2024-05-13_105903](https://private-user-images.githubusercontent.com/1952412/330458883-ee3a8461-3da0-4691-889c-0a4d0091d0a0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODUxNDYsIm5iZiI6MTczOTY4NDg0NiwicGF0aCI6Ii8xOTUyNDEyLzMzMDQ1ODg4My1lZTNhODQ2MS0zZGEwLTQ2OTEtODg5Yy0wYTRkMDA5MWQwYTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMDU0NzI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjY1ZDM4NWJmNzNmNmY3NWI3NzhjYTRhZTc5ODhlODBjMGI5MWEyMmY2ZGVkMGY2OTVjODAyOGNiYmE2NmYyYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.P9aEUWwD-ja3XHY1IS8B0ThRzBAvb2HcIbbrf2e6juU)
Usage:
Functional changes
composer cs
command.