Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

euc-kr is a superset of iso-8859-1 #12540

Merged
merged 2 commits into from
Apr 29, 2024
Merged

euc-kr is a superset of iso-8859-1 #12540

merged 2 commits into from
Apr 29, 2024

Conversation

corean
Copy link
Contributor

@corean corean commented Apr 29, 2024

Description

Fix encoding issues when importing CSV files in Excel 2007

When importing CSV files into Excel 2007, there were encoding issues. While converting from ISO-8859-1 to UTF-8 worked, encoding errors persisted.

After trying various approaches, it was discovered that EUC-KR is a subset of ISO-8859-1. By adding code to handle EUC-KR encoding, the issue was resolved.

This commit addresses the encoding problems by incorporating the necessary changes to handle EUC-KR encoding when importing CSV files into Excel 2007.

Visual changes

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added this to the v3 milestone Apr 29, 2024
@danharrin danharrin added the bug Something isn't working label Apr 29, 2024
@danharrin danharrin merged commit 0a94d32 into filamentphp:3.x Apr 29, 2024
10 checks passed
@danharrin
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants