Documentation "notifications/sending-notifications": title & body attribute - Added HTML / Markdown examples #12534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camya
changed the title
danharrin
reviewed
Apr 29, 2024
danharrin
reviewed
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the "notifications/sending-notifications" documentation of Filament V3.
It adds HTML / Markdown examples for the "notification title & body" attribute. In V2 Markdown was parsed automatically. In V3 this has to be done manually. The example shows how to do it.
See @pxlrbt comment / request for a PR on Discord: https://discord.com/channels/883083792112300104/1233674906995130408/1234164194987737249
Original question asked on Discord:
In V3, Markdown is not parsed when I do
Notification::make()->body('Some **bold** text')->>send();Is there a replacement method to parse the body?
There is no mention of this change in the V3 documentation or in the "Upgrading from v2.x" guide. It would be great, if the documentation can be updated here.
V3 docs: https://filamentphp.com/docs/3.x/notifications/sending-notifications#setting-body-text
V2 docs: https://filamentphp.com/docs/2.x/notifications/sending-notifications#body