Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/generate model and factory automatically on resource command #12479

Merged
merged 11 commits into from
Apr 28, 2024
Merged

Feature/generate model and factory automatically on resource command #12479

merged 11 commits into from
Apr 28, 2024

Conversation

Gabrielcefetzada
Copy link
Contributor

@Gabrielcefetzada Gabrielcefetzada commented Apr 24, 2024 •
edited
Loading

Description

This PR closes #11089

This feature creates automatically model and factory when passing --model AND/OR --factory argument to make:filament-resource command

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the enhancement New feature or request label Apr 26, 2024
@danharrin danharrin added this to the v3 milestone Apr 26, 2024
@danharrin danharrin self-assigned this Apr 26, 2024
danharrin
danharrin requested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please refactor this into separate flags --model and --factory though, and put them BEFORE --force

@Gabrielcefetzada
Copy link
Contributor Author

Thanks! Please refactor this into separate flags --model and --factory though, and put them BEFORE --force

Done!

@danharrin danharrin merged commit 5bb040c into filamentphp:3.x Apr 28, 2024
10 checks passed
@danharrin
Copy link
Member

Thanks, also added migration support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danharrin danharrin Awaiting requested review from danharrin

Assignees

@danharrin danharrin

Labels
enhancement New feature or request
Projects
Roadmap
Archived in project
Milestone
v3
Development

Successfully merging this pull request may close these issues.

Command to create model/factory alongside resource
2 participants
@Gabrielcefetzada @danharrin