Skip to content

Commit

Permalink
Merge pull request #15474 from filamentphp/improve-color-contrast
Browse files Browse the repository at this point in the history
Improve color contrast
  • Loading branch information
danharrin authored Jan 30, 2025
2 parents e81b089 + b6ee723 commit 44abd7a
Show file tree
Hide file tree
Showing 215 changed files with 2,578 additions and 708 deletions.
4 changes: 2 additions & 2 deletions docs-assets/app/public/css/filament/filament/app.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs-assets/app/public/css/filament/forms/forms.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs-assets/app/public/css/filament/support/support.css

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions packages/actions/src/Concerns/CanOpenModal.php
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ trait CanOpenModal
protected string | Closure | null $modalIcon = null;

/**
* @var string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null
* @var string | array<int | string, string | int> | Closure | null
*/
protected string | array | Closure | null $modalIconColor = null;

Expand Down Expand Up @@ -145,7 +145,7 @@ public function modalIcon(string | Closure | null $icon = null): static
}

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function modalIconColor(string | array | Closure | null $color = null): static
{
Expand Down Expand Up @@ -691,7 +691,7 @@ public function getModalIcon(): ?string
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null
* @return string | array<int | string, string | int> | null
*/
public function getModalIconColor(): string | array | null
{
Expand Down
4 changes: 2 additions & 2 deletions packages/forms/dist/index.css

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions packages/forms/src/Components/Concerns/HasAffixes.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ trait HasAffixes
protected string | Closure | null $prefixIcon = null;

/**
* @var string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null
* @var string | array<int | string, string | int> | Closure | null
*/
protected string | array | Closure | null $prefixIconColor = null;

protected string | Closure | null $suffixIcon = null;

/**
* @var string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null
* @var string | array<int | string, string | int> | Closure | null
*/
protected string | array | Closure | null $suffixIconColor = null;

Expand Down Expand Up @@ -138,7 +138,7 @@ public function prefixIcon(string | Closure | null $icon, bool | Closure $isInli
}

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function prefixIconColor(string | array | Closure | null $color = null): static
{
Expand All @@ -156,7 +156,7 @@ public function suffixIcon(string | Closure | null $icon, bool | Closure $isInli
}

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function suffixIconColor(string | array | Closure | null $color = null): static
{
Expand Down Expand Up @@ -242,15 +242,15 @@ public function getSuffixIcon(): ?string
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null
* @return string | array<int | string, string | int> | null
*/
public function getPrefixIconColor(): string | array | null
{
return $this->evaluate($this->prefixIconColor);
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null
* @return string | array<int | string, string | int> | null
*/
public function getSuffixIconColor(): string | array | null
{
Expand Down
8 changes: 4 additions & 4 deletions packages/forms/src/Components/Concerns/HasColors.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
trait HasColors
{
/**
* @var array<string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null> | Arrayable | Closure | null
* @var array<string | array<int | string, string | int> | null> | Arrayable | Closure | null
*/
protected array | Arrayable | Closure | null $colors = null;

/**
* @param array<string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null> | Arrayable | Closure | null $colors
* @param array<string | array<int | string, string | int> | null> | Arrayable | Closure | null $colors
*/
public function colors(array | Arrayable | Closure | null $colors): static
{
Expand All @@ -25,15 +25,15 @@ public function colors(array | Arrayable | Closure | null $colors): static
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null
* @return string | array<int | string, string | int> | null
*/
public function getColor(mixed $value): string | array | null
{
return $this->getColors()[$value] ?? null;
}

/**
* @return array<string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null>
* @return array<string | array<int | string, string | int> | null>
*/
public function getColors(): array
{
Expand Down
6 changes: 3 additions & 3 deletions packages/forms/src/Components/Concerns/HasHint.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ trait HasHint
protected array $hintActions = [];

/**
* @var string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null
* @var string | array<int | string, string | int> | Closure | null
*/
protected string | array | Closure | null $hintColor = null;

Expand Down Expand Up @@ -62,7 +62,7 @@ public function hint(string | Htmlable | Closure | null $hint): static
}

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function hintColor(string | array | Closure | null $color): static
{
Expand Down Expand Up @@ -112,7 +112,7 @@ public function getHint(): string | Htmlable | null
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null
* @return string | array<int | string, string | int> | null
*/
public function getHintColor(): string | array | null
{
Expand Down
12 changes: 6 additions & 6 deletions packages/forms/src/Components/Concerns/HasToggleColors.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@
trait HasToggleColors
{
/**
* @var string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null
* @var string | array<int | string, string | int> | Closure | null
*/
protected string | array | Closure | null $offColor = null;

/**
* @var string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null
* @var string | array<int | string, string | int> | Closure | null
*/
protected string | array | Closure | null $onColor = null;

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function offColor(string | array | Closure | null $color): static
{
Expand All @@ -27,7 +27,7 @@ public function offColor(string | array | Closure | null $color): static
}

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function onColor(string | array | Closure | null $color): static
{
Expand All @@ -37,15 +37,15 @@ public function onColor(string | array | Closure | null $color): static
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null
* @return string | array<int | string, string | int> | null
*/
public function getOffColor(): string | array | null
{
return $this->evaluate($this->offColor);
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null
* @return string | array<int | string, string | int> | null
*/
public function getOnColor(): string | array | null
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
},
match ($color) {
'gray' => 'text-gray-400 dark:text-gray-500',
default => 'fi-color text-custom-500 dark:text-custom-400',
default => 'fi-color text-color-500 dark:text-color-400',
},
is_string($color) ? 'fi-color-' . $color : null,
])
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
'fi-in-text-item-icon size-5 shrink-0',
match ($iconColor) {
'gray', null => 'text-gray-400 dark:text-gray-500',
default => 'text-custom-500',
default => 'text-color-500',
},
]);
Expand Down Expand Up @@ -170,7 +170,7 @@
match ($color) {
null => 'text-gray-950 dark:text-white',
'gray' => 'text-gray-500 dark:text-gray-400',
default => 'text-custom-600 dark:text-custom-400',
default => 'text-color-600 dark:text-color-400',
} => $isBulleted,
])
@style([
Expand Down Expand Up @@ -224,7 +224,7 @@
match ($color) {
null => 'text-gray-950 dark:text-white',
'gray' => 'text-gray-500 dark:text-gray-400',
default => 'text-custom-600 dark:text-custom-400',
default => 'text-color-600 dark:text-color-400',
},
match ($weight) {
FontWeight::Thin, 'thin' => 'font-thin',
Expand Down
6 changes: 3 additions & 3 deletions packages/infolists/src/Components/Concerns/HasColor.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
trait HasColor
{
/**
* @var string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | bool | Closure | null
* @var string | array<int | string, string | int> | bool | Closure | null
*/
protected string | array | bool | Closure | null $color = null;

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | bool | Closure | null $color
* @param string | array<int | string, string | int> | bool | Closure | null $color
*/
public function color(string | array | bool | Closure | null $color): static
{
Expand Down Expand Up @@ -50,7 +50,7 @@ public function colors(array | Closure $colors): static
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null
* @return string | array<int | string, string | int> | null
*/
public function getColor(mixed $state): string | array | null
{
Expand Down
6 changes: 3 additions & 3 deletions packages/infolists/src/Components/Concerns/HasHint.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ trait HasHint
protected array $hintActions = [];

/**
* @var string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null
* @var string | array<int | string, string | int> | Closure | null
*/
protected string | array | Closure | null $hintColor = null;

Expand Down Expand Up @@ -61,7 +61,7 @@ public function hint(string | Htmlable | Closure | null $hint): static
}

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function hintColor(string | array | Closure | null $color): static
{
Expand Down Expand Up @@ -111,7 +111,7 @@ public function getHint(): string | Htmlable | null
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null
* @return string | array<int | string, string | int> | null
*/
public function getHintColor(): string | array | null
{
Expand Down
6 changes: 3 additions & 3 deletions packages/infolists/src/Components/Concerns/HasIconColor.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
trait HasIconColor
{
/**
* @var string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null
* @var string | array<int | string, string | int> | Closure | null
*/
protected string | array | Closure | null $iconColor = null;

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function iconColor(string | array | Closure | null $color): static
{
Expand All @@ -22,7 +22,7 @@ public function iconColor(string | array | Closure | null $color): static
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null
* @return string | array<int | string, string | int> | null
*/
public function getIconColor(mixed $state): string | array | null
{
Expand Down
18 changes: 9 additions & 9 deletions packages/infolists/src/Components/IconEntry.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ class IconEntry extends Entry
protected bool | Closure | null $isBoolean = null;

/**
* @var string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null
* @var string | array<int | string, string | int> | Closure | null
*/
protected string | array | Closure | null $falseColor = null;

protected string | Closure | null $falseIcon = null;

/**
* @var string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null
* @var string | array<int | string, string | int> | Closure | null
*/
protected string | array | Closure | null $trueColor = null;

Expand All @@ -46,7 +46,7 @@ public function boolean(bool | Closure $condition = true): static
}

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function false(string | Closure | null $icon = null, string | array | Closure | null $color = null): static
{
Expand All @@ -57,7 +57,7 @@ public function false(string | Closure | null $icon = null, string | array | Clo
}

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function falseColor(string | array | Closure | null $color): static
{
Expand All @@ -76,7 +76,7 @@ public function falseIcon(string | Closure | null $icon): static
}

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function true(string | Closure | null $icon = null, string | array | Closure | null $color = null): static
{
Expand All @@ -87,7 +87,7 @@ public function true(string | Closure | null $icon = null, string | array | Clos
}

/**
* @param string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | Closure | null $color
* @param string | array<int | string, string | int> | Closure | null $color
*/
public function trueColor(string | array | Closure | null $color): static
{
Expand Down Expand Up @@ -137,7 +137,7 @@ public function getIcon(mixed $state): ?string
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string} | null
* @return string | array<int | string, string | int> | null
*/
public function getColor(mixed $state): string | array | null
{
Expand All @@ -157,7 +157,7 @@ public function getColor(mixed $state): string | array | null
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string}
* @return string | array<int | string, string | int>
*/
public function getFalseColor(): string | array
{
Expand All @@ -172,7 +172,7 @@ public function getFalseIcon(): string
}

/**
* @return string | array{50: string, 100: string, 200: string, 300: string, 400: string, 500: string, 600: string, 700: string, 800: string, 900: string, 950: string}
* @return string | array<int | string, string | int>
*/
public function getTrueColor(): string | array
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
'fi-no-notification-icon',
match ($color) {
'gray' => 'text-gray-400',
default => 'fi-color text-custom-400',
default => 'fi-color text-color-400',
},
is_string($color) ? 'fi-color-' . $color : null,
match ($size) {
Expand Down
Loading

0 comments on commit 44abd7a

Please sign in to comment.