Fixes hidden toggleable column being shown in column toggle dropdown

filamentphp · May 18, 2024 · 1d9caff · 1d9caff
1 parent 66f7a2b
commit 1d9caff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/tables/src/Concerns/CanToggleColumns.php b/packages/tables/src/Concerns/CanToggleColumns.php
@@ -62,7 +62,7 @@ protected function getTableColumnToggleFormSchema(): array
         $schema = [];
 
         foreach ($this->getTable()->getColumns() as $column) {
-            if (! $column->isToggleable()) {
+            if (! $column->isToggleable() || $column->isHidden()) {
                 continue;
             }
 

diff --git a/packages/tables/src/Table/Concerns/CanToggleColumns.php b/packages/tables/src/Table/Concerns/CanToggleColumns.php
@@ -107,7 +107,7 @@ public function getColumnToggleFormWidth(): MaxWidth | string | null
     public function hasToggleableColumns(): bool
     {
         foreach ($this->getColumns() as $column) {
-            if (! $column->isToggleable()) {
+            if (! $column->isToggleable() || $column->isHidden()) {
                 continue;
             }