Skip to content

Commit

Permalink
Merge pull request #12832 from borjajimnz/feature/modal_option_disabl…
Browse files Browse the repository at this point in the history
…e_escape_hitting

Feature: Added the option to modals to prevent closing on escape key press
  • Loading branch information
danharrin authored May 20, 2024
2 parents 3960a09 + e99337f commit 082b4d2
Show file tree
Hide file tree
Showing 6 changed files with 54 additions and 2 deletions.
23 changes: 23 additions & 0 deletions packages/actions/docs/04-modals.md
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,29 @@ use Filament\Support\View\Components\Modal;
Modal::closedByClickingAway(false);
```

## Closing the modal by escaping

By default, when you press escape on a modal, it will close itself. If you wish to disable this behavior for a specific action, you can use the `closedByEscaping(false)` method:

```php
Action::make('updateAuthor')
->form([
// ...
])
->action(function (array $data): void {
// ...
})
->closedByEscaping(false)
```

If you'd like to change the behaviour for all modals in the application, you can do so by calling `Modal::closedByEscaping()` inside a service provider or middleware:

```php
use Filament\Support\View\Components\Modal;

Modal::closedByEscaping(false);
```

## Hiding the modal close button

By default, modals have a close button in the top right corner. If you wish to hide the close button, you can use the `modalCloseButton(false)` method:
Expand Down
5 changes: 5 additions & 0 deletions packages/actions/resources/views/components/modals.blade.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
:alignment="$action?->getModalAlignment()"
:close-button="$action?->hasModalCloseButton()"
:close-by-clicking-away="$action?->isModalClosedByClickingAway()"
:close-by-escaping="$action?->isModalClosedByEscaping()"
:description="$action?->getModalDescription()"
display-classes="block"
:extra-modal-window-attribute-bag="$action?->getExtraModalWindowAttributeBag()"
Expand Down Expand Up @@ -68,6 +69,7 @@
:alignment="$action?->getModalAlignment()"
:close-button="$action?->hasModalCloseButton()"
:close-by-clicking-away="$action?->isModalClosedByClickingAway()"
:close-by-escaping="$action?->isModalClosedByEscaping()"
:description="$action?->getModalDescription()"
display-classes="block"
:extra-modal-window-attribute-bag="$action?->getExtraModalWindowAttributeBag()"
Expand Down Expand Up @@ -122,6 +124,7 @@
:alignment="$action?->getModalAlignment()"
:close-button="$action?->hasModalCloseButton()"
:close-by-clicking-away="$action?->isModalClosedByClickingAway()"
:close-by-escaping="$action?->isModalClosedByEscaping()"
:description="$action?->getModalDescription()"
display-classes="block"
:extra-modal-window-attribute-bag="$action?->getExtraModalWindowAttributeBag()"
Expand Down Expand Up @@ -182,6 +185,7 @@
:alignment="$action?->getModalAlignment()"
:close-button="$action?->hasModalCloseButton()"
:close-by-clicking-away="$action?->isModalClosedByClickingAway()"
:close-by-escaping="$action?->isModalClosedByEscaping()"
:description="$action?->getModalDescription()"
display-classes="block"
:extra-modal-window-attribute-bag="$action?->getExtraModalWindowAttributeBag()"
Expand Down Expand Up @@ -242,6 +246,7 @@
:alignment="$action?->getModalAlignment()"
:close-button="$action?->hasModalCloseButton()"
:close-by-clicking-away="$action?->isModalClosedByClickingAway()"
:close-by-escaping="$action?->isModalClosedByEscaping()"
:description="$action?->getModalDescription()"
display-classes="block"
:extra-modal-window-attribute-bag="$action?->getExtraModalWindowAttributeBag()"
Expand Down
14 changes: 14 additions & 0 deletions packages/actions/src/Concerns/CanOpenModal.php
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ trait CanOpenModal

protected bool | Closure | null $isModalClosedByClickingAway = null;

protected bool | Closure | null $isModalClosedByEscaping = null;

protected string | Closure | null $modalIcon = null;

/**
Expand All @@ -94,6 +96,13 @@ public function closeModalByClickingAway(bool | Closure | null $condition = true
return $this;
}

public function closeModalByEscaping(bool | Closure | null $condition = true): static
{
$this->isModalClosedByEscaping = $condition;

return $this;
}

/**
* @deprecated Use `modalAlignment(Alignment::Center)` instead.
*/
Expand Down Expand Up @@ -600,6 +609,11 @@ public function isModalClosedByClickingAway(): bool
return (bool) ($this->evaluate($this->isModalClosedByClickingAway) ?? Modal::$isClosedByClickingAway);
}

public function isModalClosedByEscaping(): bool
{
return (bool) ($this->evaluate($this->isModalClosedByEscaping) ?? Modal::$isClosedByEscaping);
}

/**
* @deprecated Use `makeModalSubmitAction()` instead.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
'ring-1 ring-gray-950/10 dark:ring-white/20' => (($color === 'gray') || ($tag === 'label')) && (! $grouped),
'bg-custom-600 text-white hover:bg-custom-500 focus-visible:ring-custom-500/50 dark:bg-custom-500 dark:hover:bg-custom-400 dark:focus-visible:ring-custom-400/50' => ($color !== 'gray') && ($tag !== 'label'),
'[input:checked+&]:bg-custom-600 [input:checked+&]:text-white [input:checked+&]:ring-0 [input:checked+&]:hover:bg-custom-500 dark:[input:checked+&]:bg-custom-500 dark:[input:checked+&]:hover:bg-custom-400 [input:checked:focus-visible+&]:ring-custom-500/50 dark:[input:checked:focus-visible+&]:ring-custom-400/50 [input:focus-visible+&]:z-10 [input:focus-visible+&]:ring-2 [input:focus-visible+&]:ring-gray-950/10 dark:[input:focus-visible+&]:ring-white/20' => ($color !== 'gray') && ($tag === 'label'),
]
]
),
]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
'ariaLabelledby' => null,
'closeButton' => \Filament\Support\View\Components\Modal::$hasCloseButton,
'closeByClickingAway' => \Filament\Support\View\Components\Modal::$isClosedByClickingAway,
'closeByEscaping' => \Filament\Support\View\Components\Modal::$isClosedByEscaping,
'closeEventName' => 'close-modal',
'description' => null,
'displayClasses' => 'inline-block',
Expand Down Expand Up @@ -155,7 +156,9 @@
$watch('isOpen', () => (isShown = isOpen))
})
"
x-on:keydown.window.escape="{{ $closeEventHandler }}"
@if ($closeByEscaping)
x-on:keydown.window.escape="{{ $closeEventHandler }}"
@endif
x-show="isShown"
x-transition:enter="duration-300"
x-transition:leave="duration-300"
Expand Down
7 changes: 7 additions & 0 deletions packages/support/src/View/Components/Modal.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ class Modal

public static bool $isClosedByClickingAway = true;

public static bool $isClosedByEscaping = true;

public static function closeButton(bool $condition = true): void
{
static::$hasCloseButton = $condition;
Expand All @@ -17,4 +19,9 @@ public static function closedByClickingAway(bool $condition = true): void
{
static::$isClosedByClickingAway = $condition;
}

public static function closedByEscaping(bool $condition = true): void
{
static::$isClosedByEscaping = $condition;
}
}

0 comments on commit 082b4d2

Please sign in to comment.