Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validação de senha BugFix-US04 #11

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Validação de senha BugFix-US04 #11

wants to merge 13 commits into from

Conversation

rFaelxs
Copy link

@rFaelxs rFaelxs commented Jan 27, 2025

Solve Documentação

Validação de senha BugFix-US04

  • Resolve (# numero )

Descrição

Segurança de senha e aparição dos requisitos para cadastro de senha seguindo a segurança requisitada.

Tipos de mudança

  • Bugfix
  • Melhoria de funcionalidade
  • Nova funcionalidade
  • [] Documentação

Checklist

  • Lint e testes passaram localmente com minhas mudanças
  • Eu adicionei testes que provam que minha correção é eficaz ou que minha feature funciona
  • [] Adicionei informações necessárias na documentação (se precisar)

Observações adicionais

Nenhuma constatação

Co-authored-by: Gabriel Augusto Vilar <[email protected]>
@rFaelxs rFaelxs added the bug Something isn't working label Jan 27, 2025
leafrse and others added 2 commits January 28, 2025 23:51
Co-authored-by: Gabriel Augusto Vilar <[email protected]>
Co-authored-by: Gabriel Augusto Vilar <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talvez por mudança de atributos os testes deste arquivo apresetaram erro, vejam se consegue resolver sozinho e me contatem por favor

Copy link
Contributor

@mateusmaiamaia mateusmaiamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por conta da alteração algumas funções deixaram de passar em alguns testes, verifique novamente as funções alteradas e os testes criados para essas funções:

  • AuthService › signUp › should throw an error if user already exists
  • AuthService › signIn with keepLoggedIn › should return a token with 30m expiration when keepLoggedIn is false
  • AuthService › signIn with keepLoggedIn › should return a token with 7d expiration when keepLoggedIn is true

Copy link

sonarqubecloud bot commented Feb 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants