Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): introduce validation-utils package to reduce duplicated code #5651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dsinghvi
Copy link
Member

Description

There are several duplicate definitions of ValidationViolation and RuleViolation. This PR centralizes those definitions so that we can start improving upon them.

Changes Made

  • Create a validation-utils package
  • Update all references to ValidationViolation and RuleViolation to be imported from the utils package.

Testing

  • Unit tests added/updated
  • Manual testing completed

@dsinghvi dsinghvi marked this pull request as ready for review January 19, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant