Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, java: leverage callTimeout instead of readTimeout for RequestOptions timeout configuration #3031

Merged
merged 5 commits into from
Feb 24, 2024

Conversation

armandobelardo
Copy link
Contributor

No description provided.

@armandobelardo armandobelardo enabled auto-merge (squash) February 22, 2024 22:12
@dsinghvi
Copy link
Member

This is probably what we want the generation to look like:

# core.ClientUtilities.java

public static final OkHttpUtilities {
  
  private OkHttpUtilities {
  }

  public static void withTimeout(RequestOptions requestOptions) {
    return Client.builder()...
  }
}

and then we can have it be consumed

if (requestOptions.timeout().isPresent()) {
  client = OkHttpClientUtilities.withTimeout(requestOptions);
}

@armandobelardo armandobelardo merged commit fb0814d into main Feb 24, 2024
19 checks passed
@armandobelardo armandobelardo deleted the ab/improvejavatimeout branch February 24, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants