Fix "Branch name doesn't conform to GIT standards" error with transforma... #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmation
A hg repository I successfully cloned using git-hg-remote gave the
following error on subsequent use of "git fetch" in the
.git/fast_import_crash_XXXX log:
fatal: Branch name doesn't conform to GIT standards: BRANCH.
I guessed that it might be the use of the "." in the branch name in hg
and applied this patch to my copy of git-hg-remote. That seemed to fix
the problem (and allowed a whole load of other tags into the clone that
had previously been skipped during the initial 'git clone hg::'
operation).
All this patch does is add to the transformations already present in
hgref() and gitref() to replace "." in hg refnames with "__DOT__" in the
git names. It's not ideal, but it allowed me to successfully complete
the "git fetch".
I'm not entirely convinced that the error from "git fast-import" is
valid, as I've used "." myself in tag names in pure git repos in the
past without difficulty in the past.
|
Git allows . inside of a refname, but not at the start or end. So "bran.ch" would work, but "branch." not. |
|
A better solution to the issue offered by @Benabik in branch Benabik:master in commit 0669be9. |
|
The solution by @Benabik looks fine by me. |
|
I've just encountered this: (in Obviously, escaping leading and trailing periods is far from enough here. What about using URL-encoding for anything not permitted by GIT (because |
This was referenced Oct 12, 2018
|
I've made a PR with the above suggestion: #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...tion
A hg repository I successfully cloned using git-hg-remote gave the
following error on subsequent use of "git fetch" in the
.git/fast_import_crash_XXXX log:
I guessed that it might be the use of the "." in the branch name in hg
and applied this patch to my copy of git-hg-remote. That seemed to fix
the problem (and allowed a whole load of other tags into the clone that
had previously been skipped during the initial 'git clone hg::'
operation).
All this patch does is add to the transformations already present in
hgref() and gitref() to replace "." in hg refnames with "DOT" in the
git names. It's not ideal, but it allowed me to successfully complete
the "git fetch".
I'm not entirely convinced that the error from "git fast-import" is
valid, as I've used "." myself in tag names in pure git repos in the
past without difficulty in the past.