Merge pull request #183 from amsantavicca/ams/compute-429

Count 429 responses for Compute services
fastly · Feb 24, 2025 · fa83b0d · fa83b0d
2 parents 663a710 + 8b1e0a4
commit fa83b0d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/pkg/origin/process.go b/pkg/origin/process.go
@@ -74,6 +74,7 @@ func process(serviceID, serviceName, datacenter, origin string, stats Stats, m *
 	m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "403").Add(float64(stats.ComputeStatus403))
 	m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "404").Add(float64(stats.ComputeStatus404))
 	m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "416").Add(float64(stats.ComputeStatus416))
+	m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "429").Add(float64(stats.ComputeStatus429))
 	m.StatusGroupTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "4xx").Add(float64(stats.ComputeStatus4xx))
 	m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "500").Add(float64(stats.ComputeStatus500))
 	m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "501").Add(float64(stats.ComputeStatus501))

diff --git a/pkg/rt/common_test.go b/pkg/rt/common_test.go
@@ -4939,6 +4939,7 @@ var expectedOriginsMetricsOutputMap = map[string]float64{
 	`testspace_origin_status_code_total{datacenter="TYO",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="403"}`:    4,
 	`testspace_origin_status_code_total{datacenter="TYO",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="404"}`:    0,
 	`testspace_origin_status_code_total{datacenter="TYO",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="416"}`:    0,
+	`testspace_origin_status_code_total{datacenter="TYO",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="429"}`:    0,
 	`testspace_origin_status_code_total{datacenter="TYO",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="500"}`:    0,
 	`testspace_origin_status_code_total{datacenter="TYO",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="501"}`:    0,
 	`testspace_origin_status_code_total{datacenter="TYO",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="502"}`:    0,
@@ -5058,6 +5059,7 @@ var expectedOriginsMetricsAggOutputMap = map[string]float64{
 	`testspace_origin_status_code_total{datacenter="aggregate",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="403"}`:    4,
 	`testspace_origin_status_code_total{datacenter="aggregate",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="404"}`:    0,
 	`testspace_origin_status_code_total{datacenter="aggregate",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="416"}`:    0,
+	`testspace_origin_status_code_total{datacenter="aggregate",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="429"}`:    0,
 	`testspace_origin_status_code_total{datacenter="aggregate",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="500"}`:    0,
 	`testspace_origin_status_code_total{datacenter="aggregate",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="501"}`:    0,
 	`testspace_origin_status_code_total{datacenter="aggregate",origin="testorigin",service_id="my-service-id",service_name="my-service-name",source="compute",status_code="502"}`:    0,