-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add usage trend #3374
base: next
Are you sure you want to change the base?
chore: add usage trend #3374
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3374 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2811 2811
Lines 217035 217035
Branches 940 941 +1
=======================================
Hits 216982 216982
Misses 53 53 |
Thank you for your contribution! The addition of the usage trend feature is a good idea to provide insights into the popularity of the package. However, I have a few points for discussion:
Please let me know what you think about my concerns. |
Do you have a GitHub repo/issue tracker as well? |
If this is not an official NPM project i think you are supposed to request permission from npm, Inc first to use "npm" in your product name. |
Hi, I’d like to suggest adding a dynamic NPM downloads trend image to the README of faker-js. This image would visually highlight the growth in popularity of the package over the past 3 years, helping new users see that the package is actively maintained and gaining popularity.
As a maintainer of npm-compare.com, a platform offering insights into NPM package trends, I believe this PR could give potential users more confidence in adopting faker-js for their projects. It provides a clear and real-time view of the package's increasing usage.
If there are any additional features from npm-compare.com that could further benefit the faker-js project, I’d be more than happy to implement them as well.
Thank you for considering my suggestion. I look forward to your feedback and the opportunity to contribute to this awesome project!