Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert page query param to number #433

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

ip512
Copy link
Contributor

@ip512 ip512 commented May 30, 2024

No description provided.

@ip512 ip512 force-pushed the fix/pagination-page-type branch from 6ad4f1a to e78ef2d Compare May 30, 2024 16:37
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.97%. Comparing base (dd46fcd) to head (e78ef2d).

Files Patch % Lines
src/Infrastructure/Common/DTO/PaginationDTO.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   91.01%   90.97%   -0.04%     
==========================================
  Files         184      184              
  Lines        2114     2116       +2     
  Branches      153      153              
==========================================
+ Hits         1924     1925       +1     
- Misses        184      185       +1     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ip512 ip512 merged commit de0a20a into master May 30, 2024
2 of 4 checks passed
@ip512 ip512 deleted the fix/pagination-page-type branch May 30, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants