Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate-command-markdown.py doesn't work --commands option #1020

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JamBalaya56562
Copy link

Description

I ran the ./scripts/generate-command-markdown.py --commands pull to update my another PR.
However, it shows the below error.

Traceback (most recent call last):
  File "/home/jam/workspace/sapling/website/./scripts/generate-command-markdown.py", line 462, in <module>
    main(args)
    ~~~~^^^^^^
  File "/home/jam/workspace/sapling/website/./scripts/generate-command-markdown.py", line 403, in main
    command_list = args.commands.split(",")
                   ^^^^^^^^^^^^^^^^^^^
AttributeError: 'list' object has no attribute 'split'

To fix this error, I removed the split(",") and ran again.
Finally I could regenerate the pull.md with the SUCCESS message.

extracting documentation from Sapling ...
translating rst to markdown ...
Regenerating documentation ...
Signing files ...
SUCCESS

In conclusion, I fixed generate-command-markdown.py --commands option.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants