Skip to content

Commit

Permalink
Add conversion from clock to postion and trace in a few locations
Browse files Browse the repository at this point in the history
Summary:
# Context

We are introducing EdenFS notifications to support scalable and ergonomic file system notifications for EdenFS mounts.

# This Diff

* For "interoperability" we will need to convert between a Watchman clock and an EdenFS position. This diff adds clock->position and uses to do some simple tracing.

# Next Steps

* Complete the remaining FileWatcher methods

Reviewed By: MichaelCuevas

Differential Revision: D68981231

fbshipit-source-id: 4d8b2d7268573206019c733855e1197ee48789df
  • Loading branch information
jdelliot authored and facebook-github-bot committed Feb 1, 2025
1 parent cff500a commit c9150cf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions eden/fs/cli_rs/edenfs-client/src/sapling.rs
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ where
S: AsRef<str> + AsRef<Path>,
{
let path = Path::new(path);

if !included_roots.map_or(true, |roots| {
roots
.iter()
Expand Down Expand Up @@ -230,7 +229,7 @@ where
}) {
return false;
}
// Path should be included

true
}

Expand Down
2 changes: 1 addition & 1 deletion eden/fs/cli_rs/edenfs-client/src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use edenfs_error::ResultExt;
use edenfs_utils::path_from_bytes;
use serde::Serialize;

#[derive(Clone, Debug, Serialize)]
#[derive(Clone, Debug, PartialEq, Serialize)]
pub struct JournalPosition {
pub mount_generation: i64,
pub sequence_number: u64,
Expand Down

0 comments on commit c9150cf

Please sign in to comment.