Skip to content

Commit

Permalink
Fix for T214058527 ("Your diff, D68868592, broke one test")
Browse files Browse the repository at this point in the history
Summary:
This diff was created by the [Meta Engineering Agent](https://fb.workplace.com/groups/1205375940786433/permalink/1205378807452813/) to automatically fix the broken tests assigned to you / your team in T214058527:
- The agent searched for and edited the files it deemed relevant for fixing the tests
- After generating the patch, the broken test(s) were rerun to verify they now pass
- Regression tests were also run to verify CI still passes

 ---

**If this diff is the correct fix for T214058527, please accept and land the diff**. *Note that while we set a high quality bar for the agent publishing these diffs, LLM-powered agents still make mistakes, so your critical review is much appreciated and will help us improve!*

**If changes need to be made:** Please commandeer the diff, or comment with the specific changes needed.

 ---

*P.S. If you have broader feedback, please post in the [Meta Engineering Agent - Users group](https://fb.workplace.com/groups/1205375940786433)! We would love to hear from you on improving the agent to better assist you in your daily work.*

Reviewed By: muirdm

Differential Revision: D68942505

fbshipit-source-id: c944e6dc50d4b06ae6c5a3386e7661dfab8d07a9
  • Loading branch information
generatedunixname537391475639613 authored and facebook-github-bot committed Jan 31, 2025
1 parent c91189d commit c6c595b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions eden/scm/sapling/bundle2.py
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ def __exit__(self, type, exc, tb):
# Re-raising from a variable loses the original stack. So only use
# that form if we need to.
if seekerror:
raise exc
raise exc.with_traceback(tb)

self.repo.ui.debug("bundle2-input-bundle: %i parts total\n" % self.count)

Expand Down Expand Up @@ -1206,7 +1206,7 @@ def getchunks(self, ui: "Any") -> "Iterable[bytes]":
outdebug(ui, "closing payload chunk")
# abort current part payload
yield _pack(_fpayloadsize, 0)
exc.with_traceback(tb)
raise exc.with_traceback(tb)
# end of payload
outdebug(ui, "closing payload chunk")
yield _pack(_fpayloadsize, 0)
Expand Down

0 comments on commit c6c595b

Please sign in to comment.