Log method variants to Scuba as a normvector

Summary: Normvectors simplify operations like "any", "all" while being independent of order and case. They are a perfect fit for most vectors and sets.

Reviewed By: RajivTS

Differential Revision: D68889115

fbshipit-source-id: dd2451b15346c33bea3fd5ca1a90a11a0f6f1fe0

eden/mononoke/git_server/src/model/method.rs

@@ -95,6 +95,16 @@ impl GitMethodInfo {
         variants.join(",")
     }
 
+    pub fn variants_to_string_vector(&self) -> Vec<String> {
+        let mut variants = self
+            .variants
+            .iter()
+            .map(|v| v.to_string())
+            .collect::<Vec<String>>();
+        variants.sort();
+        variants
+    }
+
     pub fn standard(repo: String, method: GitMethod) -> Self {
         Self {
             repo,

eden/mononoke/git_server/src/scuba.rs

@@ -78,6 +78,10 @@ impl ScubaHandler for MononokeGitScubaHandler {
                 MononokeGitScubaKey::MethodVariants,
                 info.variants_to_string(),
             );
+            scuba.add(
+                MononokeGitScubaKey::MethodVariants,
+                info.variants_to_string_vector(),
+            );
         }
 
         if let Some(ctx) = self.request_context {

eden/mononoke/tests/integration/mononoke_git_server/test-mononoke-git-server-clone-with-scuba.t

@@ -61,3 +61,15 @@
     "poll_time_us": *, (glob)
     "poll_count": *, (glob)
     "poll_time_us": *, (glob)
+
+# Verify the method variants in scuba as a normvector
+  $ jq .normvector.method_variants "$SCUBA"
+  [
+    "standard"
+  ]
+  [
+    "standard"
+  ]
+  [
+    "standard"
+  ]