Add stats for resets rate limited

Summary: See title Reviewed By: afrind Differential Revision: D50751471 fbshipit-source-id: a2b6bd22b2ae4d37dad34a95b04510cd3701b4df
facebook · Nov 6, 2023 · f57f226 · f57f226
1 parent 1b007b9
commit f57f226
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 3 deletions.
diff --git a/proxygen/lib/http/codec/ResetsRateLimitFilter.h b/proxygen/lib/http/codec/ResetsRateLimitFilter.h
@@ -35,11 +35,15 @@ class ResetsRateLimitFilter : public RateLimitFilter {
   }
 
   void recordNumEventsInCurrentInterval(uint32_t numEvents) override {
-    // TODO: Add stats for number of resets in the current interval
+    if (httpSessionStats_) {
+      httpSessionStats_->recordResetsInInterval(numEvents);
+    }
   }
 
   void recordRateLimitBreached() override {
-    // TODO: Add stats for number of resets in the current interval
+    if (httpSessionStats_) {
+      httpSessionStats_->recordResetsRateLimited();
+    }
   }
 
   uint32_t getMaxEventsPerInvervalLowerBound() const override {

diff --git a/proxygen/lib/http/session/HTTPSessionStats.h b/proxygen/lib/http/session/HTTPSessionStats.h
@@ -42,6 +42,10 @@ class HTTPSessionStats : public TTLBAStats {
   }
   virtual void recordHeadersRateLimited() noexcept {
   }
+  virtual void recordResetsInInterval(int64_t) noexcept {
+  }
+  virtual void recordResetsRateLimited() noexcept {
+  }
 };
 
 } // namespace proxygen
diff --git a/proxygen/lib/http/stats/ThreadLocalHTTPSessionStats.cpp b/proxygen/lib/http/stats/ThreadLocalHTTPSessionStats.cpp
@@ -41,6 +41,7 @@ TLHTTPSessionStats::TLHTTPSessionStats(const std::string& prefix)
                           facebook::fb303::SUM),
       headersRateLimited(prefix + "_headers_rate_limited",
                          facebook::fb303::SUM),
+      resetsRateLimited(prefix + "_resets_rate_limited", facebook::fb303::SUM),
       txnsPerSession(prefix + "_txn_per_session",
                      1,
                      0,
@@ -75,7 +76,18 @@ TLHTTPSessionStats::TLHTTPSessionStats(const std::string& prefix)
           facebook::fb303::AVG,
           50,
           99,
-          100) {
+          100),
+      resetsInInterval(prefix + "_resets_in_interval",
+                       1 /* bucketWidth */,
+                       0 /* min */,
+                       200 /* max, keep in sync with
+                              RestsRateLimitFilter::kDefaultMaxEventsPerInterval
+                            */
+                       ,
+                       facebook::fb303::AVG,
+                       50,
+                       99,
+                       100) {
 }
 
 void TLHTTPSessionStats::recordTransactionOpened() noexcept {
@@ -191,4 +203,12 @@ void TLHTTPSessionStats::recordHeadersRateLimited() noexcept {
   headersRateLimited.add(1);
 }
 
+void TLHTTPSessionStats::recordResetsInInterval(int64_t quantity) noexcept {
+  resetsInInterval.add(quantity);
+}
+
+void TLHTTPSessionStats::recordResetsRateLimited() noexcept {
+  resetsRateLimited.add(1);
+}
+
 } // namespace proxygen
diff --git a/proxygen/lib/http/stats/ThreadLocalHTTPSessionStats.h b/proxygen/lib/http/stats/ThreadLocalHTTPSessionStats.h
@@ -46,6 +46,8 @@ class TLHTTPSessionStats : public HTTPSessionStats {
   void recordControlMsgRateLimited() noexcept override;
   void recordHeadersInInterval(int64_t quantity) noexcept override;
   void recordHeadersRateLimited() noexcept override;
+  void recordResetsInInterval(int64_t quantity) noexcept override;
+  void recordResetsRateLimited() noexcept override;
 
   BaseStats::TLCounter txnsOpen;
   BaseStats::TLCounter pendingBufferedReadBytes;
@@ -71,10 +73,12 @@ class TLHTTPSessionStats : public HTTPSessionStats {
   BaseStats::TLTimeseries ttbtxExceedLimit;
   BaseStats::TLTimeseries ctrlMsgsRateLimited;
   BaseStats::TLTimeseries headersRateLimited;
+  BaseStats::TLTimeseries resetsRateLimited;
   BaseStats::TLHistogram txnsPerSession;
   BaseStats::TLHistogram sessionIdleTime;
   BaseStats::TLHistogram ctrlMsgsInInterval;
   BaseStats::TLHistogram headersInInterval;
+  BaseStats::TLHistogram resetsInInterval;
 };
 
 } // namespace proxygen