Skip to content

Commit

Permalink
MockQuicSocketDriver fix ::good() impl
Browse files Browse the repository at this point in the history
Summary:
- fixes the `::good()` impl for `MockQuicSocketDriver`

- after `::close`, `::good()` should return false

- used by next diff in stack

Reviewed By: sharmafb

Differential Revision: D54918964

fbshipit-source-id: 5c173561378b72b1fe2b845eba86a9c730ce90c1
  • Loading branch information
hanidamlaj authored and facebook-github-bot committed Mar 21, 2024
1 parent 7b2194f commit 770fcae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion proxygen/lib/http/session/test/MockQuicSocketDriver.h
Original file line number Diff line number Diff line change
Expand Up @@ -1194,7 +1194,6 @@ class MockQuicSocketDriver : public folly::EventBase::LoopCallback {
}

void closeImpl(folly::Optional<QuicError> errorCode) {

closeConnection();
if (errorCode) {
quic::ApplicationErrorCode* err =
Expand All @@ -1208,6 +1207,7 @@ class MockQuicSocketDriver : public folly::EventBase::LoopCallback {
QuicError(LocalErrorCode::NO_ERROR, "Closing socket with no error")));
sock_->connCb_ = nullptr;
sock_->setupCb_ = nullptr;
sockGood_ = false;
}
folly::Optional<quic::ApplicationErrorCode> getConnErrorCode() {
return streams_[kConnectionStreamId].error;
Expand Down

0 comments on commit 770fcae

Please sign in to comment.