-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-table] Feature: TableCellNode add verticalAlign attribute #7077
base: main
Are you sure you want to change the base?
[lexical-table] Feature: TableCellNode add verticalAlign attribute #7077
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
a1ee990
to
2725c37
Compare
2725c37
to
1a59c67
Compare
Thank you for this PR. I think it's almost there. In order to keep the node representation in the editorState compact and the HTML output smaller, I think the default for the verticalAlign should be 'undefined' since it's 'top' by default and it should only have a value if middle or bottom and nothing if 'top'. This way, you also won't have to modify the table tests and you can add a new table test specifically testing this new feature. |
…t to "middle" or "bottom".
Description
TableCellNode adds the verticalAlign attribute so that users can control the vertical alignment of the table
Test plan
Before
Insert relevant screenshots/recordings/automated-tests
After
default.mp4
Insert relevant screenshots/recordings/automated-tests