Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-list] Fix appending an empty list for block nodes #7067

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[lexical-list] Fix appending an empty list for block nodes #7067

wants to merge 1 commit into from

Conversation

ivailop7
Copy link
Collaborator

@ivailop7 ivailop7 commented Jan 20, 2025 •
edited
Loading

Fix #6849

After:

Screen.Recording.2025-01-20.at.00.25.15.mov

@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 0:20am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 0:20am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 20, 2025
@ivailop7 ivailop7 added extended-tests Run extended e2e tests on a PR and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 20, 2025
@ivailop7 ivailop7 changed the title Fix appending an empty list before for block nodes [lexical-list] Fix appending an empty list for block nodes Jan 20, 2025
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
lexical - cjs 29.07 KB (0%)
lexical - esm 28.89 KB (0%)
@lexical/rich-text - cjs 38.04 KB (0%)
@lexical/rich-text - esm 30.98 KB (0%)
@lexical/plain-text - cjs 36.57 KB (0%)
@lexical/plain-text - esm 28.26 KB (0%)
@lexical/react - cjs 39.84 KB (0%)
@lexical/react - esm 32.34 KB (0%)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx will be requested when the pull request is marked ready for review zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka will be requested when the pull request is marked ready for review fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson will be requested when the pull request is marked ready for review acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz will be requested when the pull request is marked ready for review Fetz is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm will be requested when the pull request is marked ready for review Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon will be requested when the pull request is marked ready for review potatowagon is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: If you add a table on a list it adds it above the list and results in invalid exported HTML
2 participants
@ivailop7 @facebook-github-bot