Rename modeling layer components #3280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68735059 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3280 +/- ##
=======================================
Coverage 96.04% 96.04%
=======================================
Files 518 518
Lines 52162 52170 +8
=======================================
+ Hits 50098 50106 +8
Misses 2064 2064 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D68735059 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jan 28, 2025
Summary: Pull Request resolved: facebook#3280 Rename `Model` -> `Generator`, `ModelSpec` -> `GeneratorSpec`, `Modelbridge` -> `Adapter`. This also updates the decoders so that we can load objects stored with the previous names: e.g. decode `Models` as `Generators`. Differential Revision: D68735059
sdaulton
force-pushed
the
export-D68735059
branch
from
2f5242a to
e3004c4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68735059 |
sdaulton
force-pushed
the
export-D68735059
branch
from
e3004c4 to
3066cff
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jan 30, 2025
Summary: Pull Request resolved: facebook#3280 Rename `Model` -> `Generator`, `ModelSpec` -> `GeneratorSpec`, `Modelbridge` -> `Adapter`. This also updates the decoders so that we can load objects stored with the previous names: e.g. decode `Models` as `Generators`. Differential Revision: D68735059
|
This pull request was exported from Phabricator. Differential Revision: D68735059 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jan 30, 2025
Summary: Pull Request resolved: facebook#3280 Rename `Model` -> `Generator`, `ModelSpec` -> `GeneratorSpec`, `Modelbridge` -> `Adapter`. This also updates the decoders so that we can load objects stored with the previous names: e.g. decode `Models` as `Generators`. Differential Revision: D68735059
sdaulton
force-pushed
the
export-D68735059
branch
from
3066cff to
76cfab0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68735059 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Jan 30, 2025
Summary: Pull Request resolved: facebook#3280 Rename `Model` -> `Generator`, `ModelSpec` -> `GeneratorSpec`, `Modelbridge` -> `Adapter`. This also updates the decoders so that we can load objects stored with the previous names: e.g. decode `Models` as `Generators`. Differential Revision: D68735059
sdaulton
force-pushed
the
export-D68735059
branch
from
76cfab0 to
7ebad17
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68735059 |
sdaulton
force-pushed
the
export-D68735059
branch
from
7ebad17 to
9c48509
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Feb 3, 2025
Summary: Pull Request resolved: facebook#3280 Rename `Model` -> `Generator`, `ModelSpec` -> `GeneratorSpec`, `Modelbridge` -> `Adapter`. This also updates the decoders so that we can load objects stored with the previous names: e.g. decode `Models` as `Generators`. Differential Revision: D68735059
Summary: Pull Request resolved: facebook#3280 Rename `Model` -> `Generator`, `ModelSpec` -> `GeneratorSpec`, `Modelbridge` -> `Adapter`. This also updates the decoders so that we can load objects stored with the previous names: e.g. decode `Models` as `Generators`. Reviewed By: saitcakmak Differential Revision: D68735059
|
This pull request was exported from Phabricator. Differential Revision: D68735059 |
sdaulton
force-pushed
the
export-D68735059
branch
from
9c48509 to
4b45bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Rename
Model->Generator,ModelSpec->GeneratorSpec,Modelbridge->Adapter.This also updates the decoders so that we can load objects stored with the previous names: e.g. decode
ModelsasGenerators.Differential Revision: D68735059