Don't assume order and length is the same between observed and predicted features #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68336952 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3250 +/- ##
=======================================
Coverage 96.04% 96.04%
=======================================
Files 518 518
Lines 52162 52161 -1
=======================================
Hits 50098 50098
+ Misses 2064 2063 -1 ☔ View full report in Codecov by Sentry. |
eonofrey
force-pushed
the
export-D68336952
branch
from
7a1c2f0 to
ec456fa
Compare
eonofrey
added a commit
to eonofrey/Ax
that referenced
this pull request
Jan 29, 2025
…ted features (facebook#3250) Summary: Combining diffs D68274239 & D68294872: 1 - **D68274239 - [analysis] Don't assume order is the same in observed and predicted features** This is causing only 3 of 14 arms to show on an experiment. We're still assuming that within an observation the order of the metric names matches the order of the corresponding data. 2 - **D68294872 - [analysis] Don't assume observed and predicted metrics are the same length** Comment from [here](https://www.internalfb.com/diff/D68274239?dst_version_fbid=9435339503152040&transaction_fbid=1415387593232440): In N6432597 I encounter a `StopIteration` error when rebased on D68274239. I believe this is because `predicted.metric_names` is quite a bit longer than `observed.data.metric_names` and so there's a chance that ``` predicted_i = next( i for i in range(len(observed.data.metric_names)) if predicted.metric_names[i] == metric_name ) ``` never finds the metric it needs and throws the `StopIteration` error. Reviewed By: danielcohenlive Differential Revision: D68336952
|
This pull request was exported from Phabricator. Differential Revision: D68336952 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68336952 |
…ted features (facebook#3250) Summary: Combining diffs D68274239 & D68294872: 1 - **D68274239 - [analysis] Don't assume order is the same in observed and predicted features** This is causing only 3 of 14 arms to show on an experiment. We're still assuming that within an observation the order of the metric names matches the order of the corresponding data. 2 - **D68294872 - [analysis] Don't assume observed and predicted metrics are the same length** Comment from [here](https://www.internalfb.com/diff/D68274239?dst_version_fbid=9435339503152040&transaction_fbid=1415387593232440): In N6432597 I encounter a `StopIteration` error when rebased on D68274239. I believe this is because `predicted.metric_names` is quite a bit longer than `observed.data.metric_names` and so there's a chance that ``` predicted_i = next( i for i in range(len(observed.data.metric_names)) if predicted.metric_names[i] == metric_name ) ``` never finds the metric it needs and throws the `StopIteration` error. Reviewed By: danielcohenlive Differential Revision: D68336952
eonofrey
force-pushed
the
export-D68336952
branch
from
ec456fa to
2bfef3e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68336952 |
|
This pull request has been merged in a4c8fe5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Combining diffs D68274239 & D68294872:
1 - D68274239 - [analysis] Don't assume order is the same in observed and predicted features
This is causing only 3 of 14 arms to show on an experiment. We're still assuming that within an observation the order of the metric names matches the order of the corresponding data.
2 - D68294872 - [analysis] Don't assume observed and predicted metrics are the same length
Comment from here:
In N6432597 I encounter a
StopIterationerror when rebased on D68274239. I believe this is becausepredicted.metric_namesis quite a bit longer thanobserved.data.metric_namesand so there's a chance thatnever finds the metric it needs and throws the
StopIterationerror.Differential Revision: D68336952