Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Groovy to version 4 #468

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Conversation

artamonovkirill
Copy link
Contributor

Groovy 4

Contents

  • Groovy 4.0.24
  • Spock 2.3-groovy-4.0
  • Gradle 7.6

Comments

Looks like some Gradle 6 plugins are still trying to pull Groovy 4 with an old groupId:

Execution failed for task ':exercises:practice:accumulate:compileGroovy'.
> Could not resolve all files for configuration ':exercises:practice:accumulate:detachedConfiguration1'.
   > Could not find org.codehaus.groovy:groovy:4.0.24.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy/4.0.24/groovy-4.0.24.pom
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project :exercises:practice:accumulate
   > Could not find org.codehaus.groovy:groovy-ant:4.0.24.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy-ant/4.0.24/groovy-ant-4.0.24.pom
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project :exercises:practice:accumulate
   > Could not find org.codehaus.groovy:groovy-templates:4.0.24.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/codehaus/groovy/groovy-templates/4.0.24/groovy-templates-4.0.24.pom
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project :exercises:practice:accumulate

Upgrading to Gradle 7+ solves the issue, so I opted to Gradle 7.6 as it works with Java 11 (the version used by the test runner at the moment).

Proof of work

./gradlew b does not fail

- Groovy 4.0.24
- Spock 2.3-groovy-4.0
- Gradle 7.6
Copy link

github-actions bot commented Jan 7, 2025

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@glennj
Copy link
Contributor

glennj commented Jan 16, 2025

I'm assuming if I review the changed files for one exercise, that applies to them all. Yes?

@artamonovkirill
Copy link
Contributor Author

I'm assuming if I review the changed files for one exercise, that applies to them all. Yes?

As mentioned on the forum, the only changes I made manually were to the bin/create_exercise.groovy and the build.gradle files; the rest were generated by running the ./gradlew wrapper task.
Should I split the PR into 2 commits (one the changes I made and one generated by the wrapper)?
You can discard the second commit, run ./gradlew wrapper yourself, and check that the result is identical.
The validation job on CI ensures the wrapper was run, but it doesn't tell you which files are autogenerated.

@artamonovkirill
Copy link
Contributor Author

Thank you!
P.S. I don't have merge permissions in the repo and will need help merging the PR 🙏

@glennj glennj merged commit 54eacb6 into exercism:main Jan 18, 2025
5 checks passed
@artamonovkirill artamonovkirill deleted the bump/groovy-4 branch January 20, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants