Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary-search exercise #48

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Add binary-search exercise #48

merged 1 commit into from
Feb 6, 2024

Conversation

pfertyk
Copy link
Contributor

@pfertyk pfertyk commented Feb 5, 2024

No description provided.

@pfertyk pfertyk force-pushed the add-binary-search-exercise branch from 5988688 to bd6044b Compare February 5, 2024 16:56
@pfertyk pfertyk marked this pull request as ready for review February 5, 2024 16:59
@pfertyk
Copy link
Contributor Author

pfertyk commented Feb 5, 2024

@BNAndras as discussed in #28, if the value is not found, we expect to receive a null. I've checked that the original Array.bsearch method in GDScript returns false in the same situation, so we're not far off :P

@BNAndras
Copy link
Member

BNAndras commented Feb 5, 2024

Do we want to return false then? It makes sense to match what’s already in the standard library. On the various Lisp language tracks, that’s what they do.

@pfertyk pfertyk force-pushed the add-binary-search-exercise branch from bd6044b to c717029 Compare February 6, 2024 17:02
@pfertyk pfertyk merged commit ca81afc into main Feb 6, 2024
2 checks passed
@pfertyk pfertyk deleted the add-binary-search-exercise branch February 6, 2024 17:05
@pfertyk
Copy link
Contributor Author

pfertyk commented Feb 6, 2024

Thanks! I've updated null to false before merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants