Add luhn exercise #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfertyk
force-pushed
the
add-luhn-exercise
branch
4 times, most recently
from
43a3713 to
5f75300
Compare
BNAndras
approved these changes
Jan 23, 2024
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "authors": [], | |||
There was a problem hiding this comment.
Needs your GitHub handle here.
| func test_is_valid_can_be_called_repeatedly(solution_script): | ||
| solution_script.card_num = "055 444 285" | ||
| return [solution_script.valid(), true] | ||
| return [solution_script.valid(), true] |
There was a problem hiding this comment.
Suggested change
| return [solution_script.valid(), true] |
Extra return line
There was a problem hiding this comment.
This is actually intentional, the rationale is given in the corresponding Python test file. I copied the comment from there, to make it clear ;)
pfertyk
force-pushed
the
add-luhn-exercise
branch
4 times, most recently
from
3c92a81 to
1fd32df
Compare
|
@BNAndras in this PR I'm also making a small change in the |
pfertyk
force-pushed
the
add-luhn-exercise
branch
from
1fd32df to
4412431
Compare
I’d probably make it a separate PR for consistency, but leaving the unrelated change in is fine for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.