Return proper error instead of KeyError for invalid fragment type name #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skovbasa
commented
Nov 8, 2024
| @@ -523,6 +517,11 @@ def visit_fragment(self, obj: Fragment) -> t.Any: | |||
| self._type[-1].name is None and obj.type_name is None | |||
| ): | |||
| graph_node = self.graph.root | |||
| elif obj.type_name not in self.graph.nodes_map: | |||
skovbasa
commented
Nov 8, 2024
| @@ -858,3 +955,19 @@ def test_any_in_option(): | |||
| 'Invalid value for option "root.get:foo", ' | |||
| '"str" instead of Mapping[String, Any]' | |||
| ] | |||
|
|
|||
|
|
|||
| def test_validate_query_fragment_on_unknown_type(): | |||
kindermax
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if fragment references non-existing type hiku throws KeyError:
This PR fixes that behavior and returns proper validation errors in that case.
There are 2 real changes, rest is the
blackformatting. I marked changes in the comments to make review easier