Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aiohttp and requests client #2

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Add aiohttp and requests client #2

merged 7 commits into from
Jan 19, 2024

Conversation

n4mespace
Copy link
Collaborator

@n4mespace n4mespace commented Jan 11, 2024 •
edited
Loading

Changes:

  • add aiohttp client
  • add requests sync client
  • fix tests

kindermax
kindermax reviewed Jan 12, 2024
View reviewed changes
featureflags_client/http/managers/aiohttp.py Outdated
)
self._session = aiohttp.ClientSession(base_url=url)

async def close_client(self) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just async def close() ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@n4mespace n4mespace merged commit e4c3514 into split-namespace-packages Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermax kindermax kindermax left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n4mespace @kindermax @dzakharchuk