Split namespace packages and add httpx client #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindermax
reviewed
Dec 26, 2023
examples/grpc/aiohttp_app.py
Outdated
| from aiohttp import web | ||
| from grpclib.client import Channel | ||
|
|
||
| from featureflags.grpc.client import FeatureFlagsClient |
There was a problem hiding this comment.
Should we rename featureflags to featureflags_client ?
kindermax
reviewed
Dec 26, 2023
featureflags/http/managers/httpx.py
Outdated
| self._refresh_task = asyncio.create_task(self._refresh_loop()) | ||
|
|
||
| async def wait_closed(self) -> None: | ||
| self._refresh_task.cancel() |
There was a problem hiding this comment.
In grpc manager, there is a separate method close which closes refresh_task. Lets try following that implementation. (Or if all in one method is desired we can rename it to async close)
n4mespace
commented
Dec 26, 2023
| if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/client-') | ||
| strategy: | ||
| matrix: | ||
| python-version: [3.7] |
There was a problem hiding this comment.
by the way, @kindermax, what minimun version should we support? can we start from 3.9/3.10 at least? maybe do a poll in dev channel?
Add aiohttp and requests client
n4mespace
force-pushed
the
split-namespace-packages
branch
from
4b5d57e to
81b0a09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
featureflags/grpc/featureflags/http/conditions.pybecause a lot was written with types from protobufsfeatureflags/http/managers/httpx.pyand example for itexamples/http/httpx_client.pyQA:
if not from
≥3.7then we can use more modern typing (just runpyupgrade)TODO:
requests/ asyncaiohttpmanagerstracer/stats_collectorto http managers