Replace #864
Merged
Replace #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertjanvanzwieten
force-pushed
the
reduce
branch
2 times, most recently
from
caedea6 to
580b6be
Compare
This patch replaces the ostack list in deep_replace_property by an IDSet for faster contains checks.
gertjanvanzwieten
force-pushed
the
reduce
branch
from
580b6be to
013eb10
Compare
This patch changes the definition of the function decorated by _util.deep_replace_property, from returning None if no replacement is made, to returning the object itself. The new definition is a more natural choice for a recursive procedure (recursion stops when a trivial loop is reached) and results in better readable code for the casual observer.
gertjanvanzwieten
force-pushed
the
reduce
branch
from
013eb10 to
052536d
Compare
joostvanzwieten
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.