rm function.replace, add deep and shallow variants #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertjanvanzwieten
force-pushed
the
replace
branch
6 times, most recently
from
4292e07 to
5d6cbca
Compare
gertjanvanzwieten
force-pushed
the
replace
branch
2 times, most recently
from
0fcf4ea to
7e2006e
Compare
gertjanvanzwieten
force-pushed
the
replace
branch
from
7e2006e to
8f1bd08
Compare
joostvanzwieten
previously approved these changes
Mar 21, 2024
gertjanvanzwieten
force-pushed
the
replace
branch
from
8f1bd08 to
4f13590
Compare
joostvanzwieten
approved these changes
Mar 21, 2024
added 3 commits
March 21, 2024 10:49
This patch adds the deep_replace_property and shallow_replace decorators to _util. The differences between the two constructs are as follows: @_util.deep_replace_property - property - intermediate values cached in object attribute - depth first - recursive @_util.shallow_replace - function - intermediate values cached only during replacement - depth last - non recursive
This patch removes the function.replace decorator and replaces it with _util.deep_replace_property (for simplified and optimized_for_numpy) and _util.shallow_replace (for replace_arguments, _deep_flatten_constants and _combine_loop_concatenates). The specialized variants are faster, use less memory, and offer better cache reuse.
gertjanvanzwieten
force-pushed
the
replace
branch
from
4f13590 to
507f0d6
Compare
gertjanvanzwieten
closed this pull request by merging all changes
into
master
in
2444961
gertjanvanzwieten
pushed a commit
that referenced
this pull request
Mar 21, 2024
This PR removes the general function.replace decorator and replaces it with the specialized deep_replace_property (used for simplified and optimized_for_numpy) and shallow_replace (used for replace_arguments, _deep_flatten_constants and _combine_loop_concatenates). The differences between the two constructs are as follows: @deep_replace_property - property - intermediate values cached in object attribute - depth first - recursive @shallow_replace - function - intermediate values cached only during replacement - depth last - non recursive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the general
function.replace decoratorand replaces it with the specializeddeep_replace_property(used forsimplifiedandoptimized_for_numpy) andshallow_replace(used forreplace_arguments,_deep_flatten_constantsand_combine_loop_concatenates). The differences between the two constructs are as follows:@deep_replace_property@shallow_replace