Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/query race condition #430

Merged
merged 7 commits into from
Feb 23, 2025
Merged

fix/query race condition #430

merged 7 commits into from
Feb 23, 2025

Conversation

euanwm
Copy link
Owner

@euanwm euanwm commented Feb 23, 2025

Suspected there was a race condition happening with queries being cached simultaneously in the list of active queries so i've migrated the cacher to be thread safe. Improvements were also made so that partial caching / matching should no longer be required.

Also caught a silly bug with the total/sinclair query param.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 27.69231% with 47 lines in your changes missing coverage. Please review.

Project coverage is 64.65%. Comparing base (32e3d5b) to head (66f6819).
Report is 8 commits behind head on development.

Files with missing lines Patch % Lines
backend/dbtools/sortby.go 13.88% 31 Missing ⚠️
backend/dbtools/cache_handler.go 44.82% 15 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #430      +/-   ##
===============================================
- Coverage        66.50%   64.65%   -1.86%     
===============================================
  Files               18       18              
  Lines              630      662      +32     
  Branches             5        5              
===============================================
+ Hits               419      428       +9     
- Misses             197      222      +25     
+ Partials            14       12       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@euanwm euanwm merged commit 9062ee8 into development Feb 23, 2025
7 of 9 checks passed
@euanwm euanwm deleted the fix/query_race_condition branch February 23, 2025 19:58
@euanwm euanwm mentioned this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant