Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 use arg.get in get_abi_input_names and get_abi_output_names #299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DavidRomanovizc
Copy link
Contributor

What was wrong?

Raised KeyError exception when name field not in ABIComponent

Related to Issue #297
Closes #297

How was it fixed?

Replace arg["name"] with arg.get("name")

And I think we need to update ABIElement in eth-typing because names are optional

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support unnamed inputs in get_abi_input_names
1 participant