Fix type checking issue with to_dict and to_ordered_dict #151
Conversation
| @@ -63,10 +63,10 @@ def inner(*args, **kwargs) -> T: # type: ignore | |||
| ) # type: Callable[[Callable[..., Iterable[TVal]]], Callable[..., Set[TVal]]] # noqa: E501 | |||
| to_dict = apply_to_return_value( | |||
| dict | |||
| ) # type: Callable[[Callable[..., Iterable[Union[Mapping[TVal, TKey], Tuple[TVal, TKey]]]]], Callable[..., Dict[TKey, TVal]]] # noqa: E501 | |||
| ) # type: Callable[[Callable[..., Iterable[Union[Mapping[TKey, TVal], Tuple[TKey, TVal]]]]], Callable[..., Dict[TKey, TVal]]] # noqa: E501 | |||
| @@ -9,7 +9,7 @@ | |||
| 'lint': [ | |||
| 'black>=18.6b4,<19', | |||
| 'flake8>=3.5.0,<4.0.0', | |||
| 'mypy<0.600', | |||
| 'mypy<0.701', | |||
eth_utils/conversions.py
Outdated
| @@ -34,7 +34,7 @@ def to_hex( | |||
| ) | |||
|
|
|||
| if is_integer(primitive): | |||
| return HexStr(hex(primitive)) | |||
| return HexStr(hex(primitive)) # type: ignore | |||
There was a problem hiding this comment.
Thoughts on a type-cast instead of an ignore?
HexStr(hex(
cast(int, primitive)
))| yield 3 | ||
|
|
||
|
|
||
| v_reversed_return: Tuple[int] = typing_reversed_return() |
There was a problem hiding this comment.
How did this pass the mypy test? Shouldn't it be Tuple[int, ...]?
There was a problem hiding this comment.
I think this is the same issue as #152 . I tried a number of things and couldn't get it to enforce the types so I dropped the tests for flatten/sorted/reversed and verified that the other tests are indeed enforcing the type. There aren't strong tests since evidently there are ways for that type of thing to silently fail, but they seem better than nothing. Right now it isn't clear how to do asserting that types are not valid easily so I'm inclined to move this forward and come back to that (opening an issue for it).
| yield 3 | ||
|
|
||
|
|
||
| v_sorted_return: Tuple[int] = typing_sorted_return() |
pipermerriam
force-pushed
the
piper/fix-typing-issue-with-to-dict
branch
from
fd61c63 to
b9be70a
Compare
What was wrong?
The
to_dictandto_ordered_dicthad incorrect type hints.Also updated to new
mypyversion that has some nice improvementsHow was it fixed?
Added a test for each of the
to_thingdecorators to validate they do indeed preserve type data correctly.Cute Animal Picture