Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[op-acceptor] periodic test running #218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scharissis
Copy link
Contributor

Description

Tests run continuously on a configurable schedule.

Tests

Added some high-level NAT tests to ensure things start/stop/run as expected.

Metadata

@scharissis scharissis requested a review from a team as a code owner March 6, 2025 05:36
@scharissis scharissis changed the title feat(op-acceptor): periodic running. [op-acceptor] periodic test running Mar 6, 2025
Copy link
Contributor

@janjakubnanista janjakubnanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the interval functionality built into the runner? As opposed to an external solution (crontab or scheduled pipelines)?

@scharissis
Copy link
Contributor Author

Thanks for the review, @janjakubnanista

Do we need the interval functionality built into the runner? As opposed to an external solution (crontab or scheduled pipelines)?

Good question. Either approach should work.
I slightly prefer this in-code approach since:

  1. It works for all deployment avenues (local, CI, k8s)
  2. It's the same code/implementation for all deployment avenues
  3. I'd rather modify Go

Did you have some concerns? Let me know if you wanted to chat further about it.

@scharissis scharissis force-pushed the scharissis/acceptor/schedule branch from 7cad7bc to 2a60867 Compare March 6, 2025 06:30
Tests run continuously on a configurable schedule.
@scharissis scharissis force-pushed the scharissis/acceptor/schedule branch from 2a60867 to 6c7cef0 Compare March 6, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nat] Run on a schedule
2 participants