Use signBlockPayload metric properly #209
Open
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelias2
approved these changes
Feb 27, 2025
|
Does the new metric need to be registered? See link |
mininny
force-pushed
the
feature/mininny/fix-signBlockPayload-metric
branch
from
5238336 to
5532ffe
Compare
You're right. Thanks for flagging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
op-signer was incorrectly using
signer_signtransaction_totalwhen signing block payload. Create a new prometheus metricsigner_signBlockPayload_totaland use that when signing block payload.