Update etcdutl migrate command: load wal records from the latest snapshot #19128
Conversation
ahrtr
force-pushed
the
etcdutl_migrate_20250106
branch
2 times, most recently
from
6fe83fd to
be38b22
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19128 +/- ##
==========================================
+ Coverage 68.77% 68.85% +0.08%
==========================================
Files 420 420
Lines 35640 35656 +16
==========================================
+ Hits 24510 24550 +40
+ Misses 9704 9684 -20
+ Partials 1426 1422 -4 Continue to review full report in Codecov by Sentry.
|
|
/retest |
ahrtr
force-pushed
the
etcdutl_migrate_20250106
branch
from
5386eef to
44cb583
Compare
serathius
dismissed
their stale review
Changes in server/etcdserver/apply/apply.go
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ahrtr
force-pushed
the
etcdutl_migrate_20250106
branch
from
44cb583 to
7f7ebde
Compare
|
@ahrtr: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -424,8 +423,9 @@ func (a *applierMembership) ClusterVersionSet(r *membershippb.ClusterVersionSetR | |||
| zap.String("new-cluster-version", newVersion.String()), | |||
| ) | |||
| } | |||
| a.snapshotServer.ForceSnapshot() | |||
There was a problem hiding this comment.
The case TestV2DeprecationSnapshotMatches failed caused by this change.
…shot Signed-off-by: Benjamin Wang <[email protected]>
When downgrading or offline migration, etcd read the maximum version from the WAL files, so as to ensure the operation is allowed. It also reads the verson from `ClusterVersionSet` request, so we should create a snapshot when cluster version chanages, so as not to block the downgrade or migration operations. Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
etcdutl_migrate_20250106
branch
from
7f7ebde to
b99b962
Compare
Resolve #17227
cc @serathius @ivanvc @jmhbnz @fuweid @siyuanfoundation
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.