all: simplify and clean up

[callthingsoff]

This patch modernizes the for-range-loop code to copy a map with "maps.Clone" and "maps.Copy", also eliminates "copyMap" and "copyFloats" functions.

Also simplify "aggSort" and "sortMap" with slices and maps functions.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[k8s-ci-robot]

Hi @callthingsoff. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.83%. Comparing base (fce823a) to head (bad008f).

Files with missing lines	Patch %	Lines
server/proxy/grpcproxy/adapter/chan_stream.go	0.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
pkg/featuregate/feature_gate.go	87.76% <100.00%> (+0.10%)	⬆️
pkg/report/report.go	93.84% <100.00%> (-0.40%)	⬇️
server/proxy/grpcproxy/adapter/chan_stream.go	55.84% <0.00%> (+0.71%)	⬆️

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19126      +/-   ##
==========================================
+ Coverage   68.79%   68.83%   +0.04%     
==========================================
  Files         420      420              
  Lines       35640    35615      -25     
==========================================
- Hits        24518    24516       -2     
+ Misses       9697     9682      -15     
+ Partials     1425     1417       -8     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce823a...bad008f. Read the comment docs.

[ivanvc]

/ok-to-test

[k8s-ci-robot]

@callthingsoff: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-robustness-amd64	bad008f	link	true	/test pull-etcd-robustness-amd64
pull-etcd-robustness-arm64	bad008f	link	true	/test pull-etcd-robustness-arm64
pull-etcd-e2e-arm64	bad008f	link	true	/test pull-etcd-e2e-arm64
pull-etcd-e2e-amd64	bad008f	link	true	/test pull-etcd-e2e-amd64
pull-etcd-e2e-386	bad008f	link	true	/test pull-etcd-e2e-386

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Test failures

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: callthingsoff
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment