Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2024-12-13] Manual Dependency Bump #19065

Merged
merged 2 commits into from
Dec 14, 2024
Merged

[2024-12-13] Manual Dependency Bump #19065

merged 2 commits into from
Dec 14, 2024

Conversation

ArkaSaha30
Copy link
Contributor

@ArkaSaha30
dependency: bump github.com/alexfalkowski/gocovmerge from 1.3.16 to 1…
3f0ee0e 
….3.17

This commit will bump dependency github.com/alexfalkowski/gocovmerge from 1.3.16 to 1.3.17

Signed-off-by: ArkaSaha30 <[email protected]>
@ArkaSaha30
dependency: bump google.golang.org/grpc from 1.68.1 to 1.69.0
e9bc263 
This commit will bump dependency google.golang.org/grpc from 1.68.1 to 1.69.0

Signed-off-by: ArkaSaha30 <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (b29d086) to head (e9bc263).
Report is 3 commits behind head on main.

Additional details and impacted files

see 16 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19065      +/-   ##
==========================================
+ Coverage   68.78%   68.82%   +0.03%     
==========================================
  Files         420      420              
  Lines       35626    35626              
==========================================
+ Hits        24505    24518      +13     
+ Misses       9695     9688       -7     
+ Partials     1426     1420       -6

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29d086...e9bc263. Read the comment docs.

@ArkaSaha30
Copy link
Contributor Author

/retest-required

ivanvc
ivanvc approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Arka

jmhbnz
jmhbnz approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ArkaSaha30

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArkaSaha30, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit c75703d into etcd-io:main Dec 14, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ivanvc ivanvc ivanvc approved these changes

Assignees
No one assigned
Labels
approved area/clientv3 area/etcdctl area/etcdutl area/testing area/tooling size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArkaSaha30 @k8s-ci-robot @ivanvc @jmhbnz