Update TestMemberAdd's context timeout by adding 5 more seconds

[ahrtr]

The test case will wait 5 seconds if waitForQuorum is true

etcd/tests/common/member_test.go

Lines 127 to 129 in 801dfc3

	if quorumTc.waitForQuorum {
	time.Sleep(etcdserver.HealthInterval)
	}

The context timeout is 10 seconds in total, but sometimes it may take a long time for the cluster to be ready, and the remaining time to run the test may < 5 seconds. In that case, the test will timeout for sure.

execute.go:47: ---> Test failed: test timed out after 4.252903074s, err: context deadline exceeded

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (801dfc3) to head (99be181).
Report is 2 commits behind head on main.

Additional details and impacted files

see 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19032      +/-   ##
==========================================
+ Coverage   68.77%   68.79%   +0.02%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
+ Hits        24498    24506       +8     
+ Misses       9699     9692       -7     
+ Partials     1426     1425       -1     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 801dfc3...99be181. Read the comment docs.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[serathius]

Please note that TestMemberAdd is the slowest test we have #18983 . Thanks for removing flakes, but maybe you have idea how to speed up the test?

[ahrtr]

TestMemberAdd is the slowest test

It's because it has too many sub cases: 5 * 4 * 2 = 40, and in some cases there is a 5 seconds sleep.

etcd/tests/common/member_test.go

Lines 112 to 114 in 801dfc3

	for _, learnerTc := range learnerTcs {
	for _, quorumTc := range quorumTcs {
	for _, clusterTc := range clusterTestCases() {

[serathius]

Right, we should think about how to remove the sleep.